3.6.2 - SQL error when add folder with roms with dupl. crc

[Tester]

Hello,

I have a combinated dat file for
Nintendo - Game Boy Advance (Good 3.14, MESS 20120305, no-Intro 20120520, NonGood 20080927, TOSEC 20120413)
the dat file works and creates a database without problems,
but when I add the rom folder I get a SQL error

multiple rows in singleton select
At procedure 'P_UPDATEROMID' line: 11, col:3
At procedure 'P_LOADFILES' line: 82, col: 1
multiple rows in singleton select
GDS Code: 335544652 - SQL Code: -811 - Error Code: 332.

I found the reason, some GoodGBA files have the same CRC but a different SHA1

game (
name "Meet the Robinsons (U)"
rom ( name "Meet the Robinsons (U) [f_4].gba" size 8388608 crc fc98748e md5 65dff45a7a35f6f69811bd9405c47387 sha1 0b9e38ac467646205167bb440fe22036f57197b3 )
rom ( name "Meet the Robinsons (U) [f_5].gba" size 8388608 crc 16c54da0 md5 4a68177c1e6080d9187b9f8dd4668031 sha1 164eca1024d6a0f5e90cd4a866cc04d5c4c24f68 )
rom ( name "Meet the Robinsons (U) [hI].gba" size 8388608 crc 3787c93c md5 28eaa16adcb92afba84f4e8284c65cbf sha1 d3754a54ab51c85caedc639a1084814970574963 )
rom ( name "Meet the Robinsons (U) [hI][f_4].gba" size 8388608 crc fc98748e md5 48c60470cf203568ec923ef8ac360338 sha1 0771dde8493d601223f9ef7fbb49bdd09445da6f )
rom ( name "Meet the Robinsons (U) [hI][f_5].gba" size 8388608 crc 16c54da0 md5 06f8d169e0e19c261c89c28a230296eb sha1 8aa68cd9f27924e7aeeee5f7fa3b0203ba37e48e )
rom ( name "Meet the Robinsons (U).gba" size 8388608 crc 3787c93c md5 cfbf47949426a8f44ecdc832d06d09a9 sha1 58ad2756f1985430e1ef605bdcba82564099a030 )
)

game (
name "Petz Vet (U)"
rom ( name "Petz Vet (U) [f_4].gba" size 8388608 crc b73771f7 md5 0bcdadab4ef9ed07477fd806cd7e277a sha1 04e0380ed20e764901493d9a49d66f2ca043e3e4 )
rom ( name "Petz Vet (U) [f_5].gba" size 8388608 crc 742d92ec md5 415d72cf996fd8af182aa3e41be4c22e sha1 dabd303945aea30a380afd6f9f9fdd5a3ec926cc )
rom ( name "Petz Vet (U) [hI].gba" size 8388608 crc 1dbf4d3d md5 978ed70eca1b3b6742f2b0b6c79bd4ac sha1 5c4d99f9d8589a2d49bfb01c77395fb4ffb1eb5c )
rom ( name "Petz Vet (U) [hI][f_4].gba" size 8388608 crc b73771f7 md5 a9c6589d1c77119595aad82ce572b07c sha1 3bf6d724727455cacc7a1e791a679b0b55da984e )
rom ( name "Petz Vet (U) [hI][f_5].gba" size 8388608 crc 742d92ec md5 1426614387eadd1cd28be9e8e3cb85ef sha1 d68a631a1def719b8665479fea9b78bf89226946 )
rom ( name "Petz Vet (U).gba" size 8388608 crc 1dbf4d3d md5 43cf1c2b7601db441295f12c538ae3a3 sha1 9755a6eaf65d10131e591c4c75b9c77554cd1dad )
)

can you please fix this?

here are the files

test.dat
Meet the Robinsons (U).7z
Petz Vet (U).7z
Nintendo - Game Boy Advance (Good 3.14, MESS 20120305, no-Intro 20120520, NonGood 20080927, TOSEC 20120413).dat.7z

[Tester]

the subject should be "3.6.2 - SQL error when add folder with roms with dublicated CRC"

[RomCenter]

Ok, thank you for the analysis. This is an error in the data. I will improve the datafile procedure to handle that.

[Tester]

Did you mean that it is a error in dat file?
The dat file is correct, the files have really the same CRC and a differen sha1, md5.

[RomCenter]

Really ?

Can you send me the two files ?

[Tester]

The links are in the first post

[Tester]

did you check the files?

[RomCenter]

I checked the files, and you're right.
But it's verry odd.

It's quite unlikely that 2 different roms have same crc, and here they are in the same game, with similar name.
They are indeed different, but imho, one has probably been hacked to get the same crc as the other.

Anyway, I have to redesign some parts of the application to handle that in the future.
I will try to include that in 3.7 branch.

Until then, you could notify the problem to the dat author.

[Tester]

I am the dat autor, the files comes from GoodGBA 3.14, I did only extact the files and did create a dat from this folder.
The files are not changed by me, you can get this files from the GoodGBA set or the complete set from several rom-websites.

[MELERIX]

GoodX is outdated in matter of DATs for Roms since years

I suggest you to use No-Intro's DATs that are really more updated and with proper hashes

http://datomatic.no-intro.org/

[Tester]

Last Good release was 02/28/2012, should I now delete all Good roms which are not in the no-Intro dat?

No thanks, this not a solution!

And when you check the first post, you will see that I allready use no-Intro and Tosec and ...

[MELERIX]

well, I had to tell you that most of the "dump teams" of the scene are working with No-Intro Dats.

and for example GoodGBx 3.14 last udpate is from around 2007~

[Tester]

again, I use no-Intro already ...